feat(Verification): report verification methods added

sinch · Aug 14, 2024 · c8f6372 · c8f6372
1 parent 8a3895f
commit c8f6372
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 23 deletions.
diff --git a/sinch/domains/verification/__init__.py b/sinch/domains/verification/__init__.py
@@ -23,7 +23,9 @@
     StartFlashCallVerificationRequest,
     StartPhoneCallVerificationRequest,
     StartDataVerificationRequest,
-    ReportVerificationByIdentityRequest,
+    ReportVerificationByIdentityAndSMSRequest,
+    ReportVerificationByIdentityAndFlashCallRequest,
+    ReportVerificationByIdentityAndPhoneCallRequest,
     ReportVerificationByIdAndSMSRequest,
     ReportVerificationByIdAndFlashCallRequest,
     ReportVerificationByIdAndPhoneCallRequest,
@@ -160,7 +162,7 @@ def report_sms_by_identity(
     ) -> ReportVerificationByIdentityResponse:
         return self._sinch.configuration.transport.request(
             ReportVerificationByIdentityEndpoint(
-                request_data=ReportVerificationByIdentityRequest(
+                request_data=ReportVerificationByIdentityAndSMSRequest(
                     endpoint,
                     code,
                     cli
@@ -176,7 +178,7 @@ def report_flash_call_by_identity(
     ) -> ReportVerificationByIdentityResponse:
         return self._sinch.configuration.transport.request(
             ReportVerificationByIdentityEndpoint(
-                request_data=ReportVerificationByIdentityRequest(
+                request_data=ReportVerificationByIdentityAndFlashCallRequest(
                     endpoint,
                     cli
                 )
@@ -191,7 +193,7 @@ def report_phone_call_by_identity (
     ) -> ReportVerificationByIdentityResponse:
         return self._sinch.configuration.transport.request(
             ReportVerificationByIdentityEndpoint(
-                request_data=ReportVerificationByIdentityRequest(
+                request_data=ReportVerificationByIdentityAndPhoneCallRequest(
                     endpoint,
                     code
                 )

diff --git a/sinch/domains/verification/models/requests.py b/sinch/domains/verification/models/requests.py
@@ -55,7 +55,22 @@ class StartDataVerificationRequest(StartVerificationRequest):
 @dataclass
 class ReportVerificationByIdentityRequest(SinchRequestBaseModel):
     endpoint: str
-    verification_report_request: dict
+
+
+@dataclass
+class ReportVerificationByIdentityAndSMSRequest(ReportVerificationByIdentityRequest):
+    code: str
+    cli: str
+
+
+@dataclass
+class ReportVerificationByIdentityAndFlashCallRequest(ReportVerificationByIdentityRequest):
+    cli: str
+
+
+@dataclass
+class ReportVerificationByIdentityAndPhoneCallRequest(ReportVerificationByIdentityRequest):
+    code: str
 
 
 @dataclass

diff --git a/tests/e2e/verification/test_report_verification_using_id.py b/tests/e2e/verification/test_report_verification_using_id.py
@@ -8,12 +8,7 @@ def test_report_verification_using_id_and_sms(
 ):
     verification_response = sinch_client_sync.verification.verifications.report_sms_by_id(
         id=verification_id,
-        verification_report_request={
-            "method": "sms",
-            "sms": {
-                "code": "2302"
-            }
-        }
+        code="2302"
     )
     assert isinstance(verification_response, ReportVerificationByIdResponse)
 
@@ -25,12 +20,7 @@ def test_report_verification_using_id_and_flash_call(
 ):
     verification_response = sinch_client_sync.verification.verifications.report_flash_call_by_id(
         id=verification_id,
-        verification_report_request={
-            "method": "sms",
-            "sms": {
-                "code": "2302"
-            }
-        }
+        cli="2332"
     )
     assert isinstance(verification_response, ReportVerificationByIdResponse)
 
@@ -42,12 +32,7 @@ def test_report_verification_using_id_and_and_phone_call(
 ):
     verification_response = sinch_client_sync.verification.verifications.report_phone_call_by_id(
         id=verification_id,
-        verification_report_request={
-            "method": "sms",
-            "sms": {
-                "code": "2302"
-            }
-        }
+        code="2302"
     )
     assert isinstance(verification_response, ReportVerificationByIdResponse)