Test unicode handling in context of SerDes #35
Conversation
650elx
requested review from
Dovchik,
krogers0607,
asein-sinch and
JPPortier
as code owners
| dial_timeout=5 | ||
| ) | ||
|
|
||
| assert isinstance(verification_response, StartFlashCallInitiateVerificationResponse) |
There was a problem hiding this comment.
nit
I suppose you can check send and receive in just one function and one mock
There was a problem hiding this comment.
Ah, also, would be nice to see a ref to the mock in PR description
There was a problem hiding this comment.
nit I suppose you can check send and receive in just one function and one mock
Wiremock is doing that behind the scenes :)
There was a problem hiding this comment.
Ah, also, would be nice to see a ref to the mock in PR description
👍
There was a problem hiding this comment.
Wiremock is doing that behind the scenes :)
Always forgot that 😅
I've forgot to update target branch with the latest changes present in main. Fixed |
Related fixtures:
https://github.com/sinch/sinch-sdk-internal-specs/blob/numbers_fixtures/fixtures/python/verification-api/mappings/verification_v1_verifications-f0c31c63-19fc-4062-8bbd-d0e96b3468e8.json
https://github.com/sinch/sinch-sdk-internal-specs/blob/numbers_fixtures/fixtures/python/verification-api/mappings/verification_v1_verifications_id_01919a50-b75b-cedb-5080-216b829e92e9-0a03359a-6c0e-4b65-aa92-f40a74e6d19a.json