DEVEXP-464 update verification API with backwards compat #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
650elx
requested review from
Dovchik,
krogers0607,
asein-sinch and
JPPortier
as code owners
Dovchik
reviewed
Oct 24, 2024
| ) -> StartVerificationResponse: | ||
| """ | ||
| This method is not supported anymore. | ||
| It should be used only for backward compatibility reasons. |
There was a problem hiding this comment.
Would be nice to specify which method to use instead
| @@ -87,6 +114,10 @@ def start_callout( | |||
| custom: str = None, | |||
| speech_locale: str = None | |||
| ) -> StartVerificationResponse: | |||
| """ | |||
| This method is not supported anymore. | |||
| It should be used only for backward compatibility reasons. | |||
| ) -> StartVerificationResponse: | ||
| """ | ||
| dial_timeout argument is not supported anymore. |
There was a problem hiding this comment.
I'm confused, can you point me in PM in which oas file it was not supported anymore 😮
There was a problem hiding this comment.
It looks like I've misunderstood the OpenAPI spec. I'll remove this docstring
Dovchik
approved these changes
Oct 28, 2024
650elx
added a commit
that referenced
this pull request
Dec 19, 2024
* DEVEXP-340/DEVEXP-471 - automated CI/CD release to PyPI and async library replacement (#29) * DEVEXP-464 update verification API with backwards compat (#36) * fix: recursion error (#38) * [SMS] service plan id version of the API (#17) * relese: bump the package version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31 PR with added backward compatibility