Altering map collarscale tooltip (placement and text) #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@colmose asked you for review as you raised a very similar issue to point 1 - https://github.com/sirensolutions/kibi-internal/issues/6826
This PR addresses 2 issues that are related to the same tool tip:
https://github.com/sirensolutions/kibi-internal/issues/9263 - The issue is that the tooltip is hidden as the default tooltip placement is "top". I changed it to "right" and the entire tooltip is visible as below:
https://github.com/sirensolutions/kibi-internal/issues/9245 - I think this tooltip is mixed up and I investigated (below is the original tooltip text, and top orienatation):
"A value too small could result in excessive fetches" - To me if the map collar scale is set to small number there will be less fetches
"A value too large could result in trimmed results and slow performance" - A high value results in trimmed results, meaning less documents, this is not correct. Further "and slow performance" can be removed (rather than swapping it with the point above as excessive fetches implies that performance is slowed down.
I did some analysis on why this should be swapped. I
Opened an ETM visualization in edit mode
Opened the network tab in dev tools
Set map collar scale to 1 and applied changes.
When looking at the number of documents I found a total of 7126:
Then I set map collar scale to 2, applied changes and got 38,429
Then I set map collar scale to 4, applied changes and got 57,033
These results indicate that a higher value is more likely to result in "excessive fetches" and a smaller value is more likely to result is "trimmed results". So I changed the tool tip accordingly