Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Altering map collarscale tooltip (placement and text) #60

Merged
merged 4 commits into from
Jul 22, 2019

Conversation

corrigancd
Copy link

@colmose asked you for review as you raised a very similar issue to point 1 - https://github.com/sirensolutions/kibi-internal/issues/6826

This PR addresses 2 issues that are related to the same tool tip:

  1. https://github.com/sirensolutions/kibi-internal/issues/9263 - The issue is that the tooltip is hidden as the default tooltip placement is "top". I changed it to "right" and the entire tooltip is visible as below:
    image

  2. https://github.com/sirensolutions/kibi-internal/issues/9245 - I think this tooltip is mixed up and I investigated (below is the original tooltip text, and top orienatation):

image

"A value too small could result in excessive fetches" - To me if the map collar scale is set to small number there will be less fetches

"A value too large could result in trimmed results and slow performance" - A high value results in trimmed results, meaning less documents, this is not correct. Further "and slow performance" can be removed (rather than swapping it with the point above as excessive fetches implies that performance is slowed down.

I did some analysis on why this should be swapped. I

  • Opened an ETM visualization in edit mode

  • Opened the network tab in dev tools

  • Set map collar scale to 1 and applied changes.

  • When looking at the number of documents I found a total of 7126:
    image

  • Then I set map collar scale to 2, applied changes and got 38,429

  • Then I set map collar scale to 4, applied changes and got 57,033

These results indicate that a higher value is more likely to result in "excessive fetches" and a smaller value is more likely to result is "trimmed results". So I changed the tool tip accordingly

@corrigancd corrigancd requested a review from colmose July 19, 2019 16:50
@corrigancd
Copy link
Author

  1. Map collar scale = 1, the query fires on every map canvas extent change. This means more fetches, less documents per fetch:
    FAC25413-9B2A-4F56-BC39-01AB346F15FB

  2. Map collar scale = 2, the bounding box is larger, therefore the query doesn't need to be fired as often. This means less fetches but larger fetches and more documents stored on front end at any one time:
    D0FA4615-7774-4B2F-AD0E-8F2386811A9A

Amended the message to this:
image

public/options.html Outdated Show resolved Hide resolved
@corrigancd corrigancd requested a review from colmose July 22, 2019 08:47
@corrigancd corrigancd merged commit 94fe78d into master Jul 22, 2019
@corrigancd corrigancd deleted the issue-9263and9245 branch July 22, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants