Fix NSToolbar preserving the visual state of previous selected pane on macOS Sonoma #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's still getting stuck for me, even with these changes. 
|
|
I changed the timing of the refresh action. There’s still a noticeable delay on state changes. But I think this issue is mitigated. |
|
Have you tested the existing toolbar (not this PR) on macOS 14.1? If not, I recommend doing that. Just in case this issue has already been fixed there, and this fix would be moot. |
|
Yeah. I updated my Mac to macOS 14.1 Developer Beta and this issue still exists.
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
2 tasks
|
@francisfeng @sindresorhus How can I set UI for dark and light? I try to set color but facing some issue on set color for Toolbar background. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in the screenshot, there’s a UI glitch on Sonoma 14.0. It can be easily reproduced by simply running the Example project and switching around the setting panes.
You won’t have this issue if you set
animatetofalseduring the initialization ofSettingsWindowController.Apple may fix this issue in a future release of Sonoma, which makes this workaround useless. But I don’t know if we should wait or not.