Add the ability to set a minimum label width on containers #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyarnold
force-pushed
the
minimum-label-widths
branch
from
b83d68c
to
0ec3487
Compare
|
Why close? |
|
Oh, this one was a mistake! The other PR needed more thinking - my changes work, but they were causing problems my project. |
tonyarnold
force-pushed
the
minimum-label-widths
branch
from
0ec3487
to
e4665fe
Compare
tonyarnold
force-pushed
the
minimum-label-widths
branch
from
e4665fe
to
02f2176
Compare
sindresorhus
reviewed
Sep 1, 2021
|
Thanks :) |
dezinezync
pushed a commit
to dezinezync/Preferences
that referenced
this pull request
Dec 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to add a new
minimumLabelWidthparameter toContainerinstances.I've found in my own preference panes, that the automatically calculated width for labels can be a bit tight, especially for wider panes.