Resolve GIT URL via 'git remote...' (#87)

sindresorhus · Jul 31, 2019 · e6202ce · e6202ce
1 parent 0aafda8
commit e6202ce
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/rules/github.js b/rules/github.js
@@ -9,9 +9,10 @@ module.exports = rule('remark-lint:awesome/github', async (ast, file) => {
 
 	try {
 		const remoteUrl = await execa.stdout('git', [
-			'config',
-			'--get',
-			'remote.origin.url'
+			'remote',
+			'get-url',
+			'--push',
+			'origin'
 		], {
 			cwd: dirname
 		});

diff --git a/test/rules/github.js b/test/rules/github.js
@@ -40,7 +40,7 @@ test.serial('github - repo without description and license', async t => {
 	const gotStub = sandbox.stub(github.got, 'get');
 
 	execaStub
-		.withArgs('git', ['config', '--get', 'remote.origin.url'])
+		.withArgs('git', ['remote', 'get-url', '--push', 'origin'])
 		.returns('git@github.com:sindresorhus/awesome-lint-test.git');
 
 	gotStub
@@ -70,7 +70,7 @@ test.serial('github - missing topic awesome-list', async t => {
 	const gotStub = sandbox.stub(github.got, 'get');
 
 	execaStub
-		.withArgs('git', ['config', '--get', 'remote.origin.url'])
+		.withArgs('git', ['remote', 'get-url', '--push', 'origin'])
 		.returns('git@github.com:sindresorhus/awesome-lint-test.git');
 
 	gotStub
@@ -99,7 +99,7 @@ test.serial('github - missing topic awesome', async t => {
 	const gotStub = sandbox.stub(github.got, 'get');
 
 	execaStub
-		.withArgs('git', ['config', '--get', 'remote.origin.url'])
+		.withArgs('git', ['remote', 'get-url', '--push', 'origin'])
 		.returns('git@github.com:sindresorhus/awesome-lint-test.git');
 
 	gotStub
@@ -127,7 +127,7 @@ test.serial('github - remote origin is an GitLab repo', async t => {
 	const execaStub = sandbox.stub(github.execa, 'stdout');
 
 	execaStub
-		.withArgs('git', ['config', '--get', 'remote.origin.url'])
+		.withArgs('git', ['remote', 'get-url', '--push', 'origin'])
 		.returns('https://gitlab.com/sindresorhus/awesome-lint-test.git');
 
 	const messages = await lint({config, filename: 'test/fixtures/github/0.md'});
@@ -144,7 +144,7 @@ test.serial('github - invalid token', async t => {
 	const gotStub = sandbox.stub(github.got, 'get');
 
 	execaStub
-		.withArgs('git', ['config', '--get', 'remote.origin.url'])
+		.withArgs('git', ['remote', 'get-url', '--push', 'origin'])
 		.returns('git@github.com:sindresorhus/awesome-lint-test.git');
 
 	gotStub
@@ -169,7 +169,7 @@ test.serial('github - API rate limit exceeded with token', async t => {
 	process.env.github_token = 'abcd';
 
 	execaStub
-		.withArgs('git', ['config', '--get', 'remote.origin.url'])
+		.withArgs('git', ['remote', 'get-url', '--push', 'origin'])
 		.returns('git@github.com:sindresorhus/awesome-lint-test.git');
 
 	gotStub
@@ -197,7 +197,7 @@ test.serial('github - API rate limit exceeded without token', async t => {
 	const gotStub = sandbox.stub(github.got, 'get');
 
 	execaStub
-		.withArgs('git', ['config', '--get', 'remote.origin.url'])
+		.withArgs('git', ['remote', 'get-url', '--push', 'origin'])
 		.returns('git@github.com:sindresorhus/awesome-lint-test.git');
 
 	gotStub
@@ -223,7 +223,7 @@ test.serial('github - API offline', async t => {
 	const gotStub = sandbox.stub(github.got, 'get');
 
 	execaStub
-		.withArgs('git', ['config', '--get', 'remote.origin.url'])
+		.withArgs('git', ['remote', 'get-url', '--push', 'origin'])
 		.returns('git@github.com:sindresorhus/awesome-lint-test.git');
 
 	gotStub