-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Software Architecture #2007
Conversation
unicorn |
I'm not sure if the author names in the descriptions are required (example). If you think they are, they should end by a dot and should be consistent with all other items (eg. some don't have a mention of their author, some have it inside the title instead of the description). Other than that, LGTM. |
@innocenzi Yes, I think it is better removing name from description. |
Personally, I think they are not needed at all, since they are on the linked page anyway: If you think they are needed, I personally would do the following, which is the most aesthetically pleasing to me:
But I don't know if that would be accepted, sorry. |
@innocenzi Thanks, I removed all authors name from description in all of my links. |
I'd suggest changing the list description in the readme. I would say the description is almost the same as this forbidden rule: ❌ Resources and tools for iOS development. described here: https://github.com/sindresorhus/awesome/blob/main/pull_request_template.md#requirements-for-your-awesome-list |
@prokopsimek I changed the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the description of my repo.
Your list does not comply with:
|
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Hi, |
Is the part I'm talking about. Awesome lists are meant to be a GitHub repo, not a website. Websites are allowed, but they should be secondary. |
@sindresorhus Yes, you're right. but because I have so many links and their nesting section, managing them in a single root readme file was difficult so I moved them to a GitHub page for better navigation and searching capability. I saw a such thing in a pre existing awesome page https://github.com/ramitsurana/awesome-kubernetes so I did same thing |
Closing for now. Open a new PR if you decide to make it a proper Awesome list. If not, that's totally fine too. Not everything has to be listed here. All Awesome lists are searchable on GitHub. |
@sindresorhus Could you open this issue again? I changed README file more like awesome list in one page, beside of this README, this repository has an official website |
https://github.com/mehdihadeli/awesome-software-architecture
Some articles and resources to learn and practice about software architecture, patterns, and principles.
PR reviewed
4 pull requests I've reviewed: #1936 , #1931 , #1944, #1947, #2006
#1947(comment)
#1936(comment)
#1931(comment)
#1944 (comment)
#2006(comment)
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. Casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.