-
-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stock Trading #2736
Add Stock Trading #2736
Conversation
unicorn |
Awesome Stock Trading looks pretty good so far - I think there can be a few areas of improvement:
|
Thank you. I took your suggestions to heart and agree with most of what you said. As for YouTube, I have to confess that I hardly use it, I'm more of a book guy. But I will look in the next few weeks to see if there is any good and substantial material. |
@shi-rudo According to the guides, the link and description are separated by a dash. The Most Important Stock Exchanges section doesn't follow that. |
I'd recommend adding a space between your heading and the awesome badge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Changed description
@sindresorhus my awesome-lint v1 does not detect those errors! awesome-finance % npx awesome-lint
✔ Linting I even checked the lines with position you mentioned. there's nothing wrong? what do I miss? ## Stock Collections
- [Growth 250](https://marketsmith.investors.com/growth250/) - MarketSmith's Growth 250 is a curated list of high-potential stocks.
- [StockTwits Top 10](https://stocktwits.com/rankings/trending) - StockTwits' list of the top 10 trending stocks. |
https://github.com/shi-rudo/awesome-stock-trading
List about valuable tools and educational resources about stock trading.
Commented pull requests:
#2391
#2734
#2692
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Requirements for your pull request
Add Name of List
. It should not contain the wordAwesome
.#readme
.Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.awesome-name-of-list
.# Awesome Name of List
.awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.