Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Transgender #2949

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add Transgender #2949

wants to merge 8 commits into from

Conversation

cvyl
Copy link

@cvyl cvyl commented Jan 22, 2024

https://github.com/cvyl/awesome-transgender

Why

I think adding a resource list for LGBTQ+/Transgender individuals under the health section is appropriate and will help those on GitHub or those who are passing by find the best resources closest to them. I hope to help others by including this addition.

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it. Instead use #2242 for incubation visibility.

  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.

  • You have to review at least 2 other open pull requests.
    Add Red-Teaming LLMs #3247 (review)
    Add WebGPU #3210 (review)
    Add RT-Thread #3048 (comment)

    Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.

  • You have read and understood the instructions for creating a list.

  • This pull request has a title in the format Add Name of List. It should not contain the word Awesome.

    • Add Swift
    • Add Software Architecture
    • Update readme.md
    • Add Awesome Swift
    • Add swift
    • add Swift
    • Adding Swift
    • Added Swift
  • Your entry here should include a short description of the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb. It should not contain the name of the list.

    • - [iOS](…) - Mobile operating system for Apple phones and tablets.
    • - [Framer](…) - Prototyping interactive UI designs.
    • - [iOS](…) - Resources and tools for iOS development.
    • - [Framer](…)
    • - [Framer](…) - prototyping interactive UI designs
  • Your entry should be added at the bottom of the appropriate category.

  • The title of your entry should be title-cased and the URL to your list should end in #readme.

    • Example: - [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
  • No blockchain-related lists.

  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • The default branch should be named main, not master.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
    • Mobile operating system for Apple phones and tablets.
    • Prototyping interactive UI designs.
    • Resources and tools for iOS development.
    • Awesome Framer packages and tools.
  • It's the result of hard work and the best I could possibly produce.
    If you have not put in considerable effort into your list, your pull request will be immediately closed.
  • The repo name of your list should be in lowercase slug format: awesome-name-of-list.
    • awesome-swift
    • awesome-web-typography
    • awesome-Swift
    • AwesomeWebTypography
  • The heading title of your list should be in title case format: # Awesome Name of List.
    • # Awesome Swift
    • # Awesome Web Typography
    • # awesome-swift
    • # AwesomeSwift
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate. Please search for existing submissions.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to a maximum of half the width of the original image.
    • Don't include both a title saying Awesome X and a logo with Awesome X. You can put the header image in a # (Markdown header) or <h1>.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
    • Must not feature Contributing or Footnotes sections.
  • Has an appropriate license.
    • We strongly recommend the CC0 license, but any Creative Commons license will work.
      • Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0 (replace <user> and <repo> accordingly).
    • A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
    • Place a file named license or LICENSE in the repo root with the license text.
    • Do not add the license name, text, or a Licence section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.
    • To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.
  • Has contribution guidelines.
    • The file should be named contributing.md. The casing is up to you.
    • It can optionally be linked from the readme in a dedicated section titled Contributing, positioned at the top or bottom of the main content.
    • The section should not appear in the Table of Contents.
  • All non-important but necessary content (like extra copyright notices, hyperlinks to sources, pointers to expansive content, etc) should be grouped in a Footnotes section at the bottom of the readme. The section should not be present in the Table of Contents.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Does not use hard-wrapping.
  • Does not include a CI (e.g. GitHub Actions) badge.
    You can still use a CI for linting, but the badge has no value in the readme.
  • Does not include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

@sindresorhus
Copy link
Owner

Thanks for making an Awesome list! 🙌

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

@cvyl
Copy link
Author

cvyl commented Jan 22, 2024

I missed 4 out of all the requirements, I do not see the problem. awesome-lint shows two errors, one of which is a false positive ( think?)

img

@wongyah
Copy link

wongyah commented Jan 31, 2024

@cvyl These are the requirements I found the PR and the list haven't meet (wish it would be helpful for you):

Requirements for your pull request

  1. Two PRs you reviewed haven't list in your comments.

  2. The PR title should be "Add Transgender", instead of "Add Transgender Resources - Awesome".

  3. The entry for Awesome Transgender should look like this:

    - [Transgender]() - A description about transgender, instead of "A list of blah blah".
    

Requirements for your Awesome list

  1. The description at the top of the readme doesn't focus on the theme of transgeder, as I mentioned in the 3rd item above.
  2. All the entries in the list have no descriptions. It is better to add some short and simple description, so that the audiences can know whether it is what they expect before they click the link.
  3. The heading2 section "Reddit" has two subsections, which doesn't follow the requirements.
  4. The section "Contribute" should be named "Contributing".
  5. The section "Contributing" should not listed in the "Contents".

@cvyl
Copy link
Author

cvyl commented Feb 28, 2024

I am unable to understand the following error:
✖ 1:1 Exceeded max depth of 2 levels remark-lint:awesome-toc

EDIT: I fixed it. It passes the lint.

@cvyl
Copy link
Author

cvyl commented Feb 29, 2024

Requesting @sindresorhus to review the changes made.

@cvyl cvyl changed the title Add Transgender Resources - Awesome Add Transgender Resources Mar 3, 2024
@cvyl cvyl changed the title Add Transgender Resources Add Transgender Mar 3, 2024
@hstsethi
Copy link

I noticed that illustration requirement is not fulfilled, so maybe add a trans flag logo as illustration?

ruru-m07

This comment was marked as abuse.

@cvyl
Copy link
Author

cvyl commented Apr 18, 2024

Hello, I'd love to receive an update on this PR's review

@cvyl
Copy link
Author

cvyl commented May 10, 2024

Once again, requesting an update.

@sindresorhus
Copy link
Owner

You have to review at least 2 other open pull requests.

@sindresorhus
Copy link
Owner

Your entry here should include a short description of the project/theme of the list. It should not describe the list itself.

@sindresorhus
Copy link
Owner

Includes a succinct description of the project/theme at the top of the readme.

@sindresorhus
Copy link
Owner

Many items are missing a description.

@cvyl
Copy link
Author

cvyl commented May 28, 2024

Thank you for your review, I will fix these issues.

Copy link
Contributor

@Polycarbohydrate Polycarbohydrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually after reviewing it looks life you fixed the lint issues but not the problems listed by sindresorhus.

I would advise you to fix them. (f.ex. Objects having no description)

I did not mean to approve this pull request for the reasons stated in this comment.

@hstsethi hstsethi mentioned this pull request Aug 25, 2024
33 tasks
@menisadi
Copy link

This is an important topic!
Notice that you have a typo on the description: should be "focused" and not "focussed"
The lint seems to pass indeed.
I agree with previous comments suggesting adding a little trans flag below the title as suggested by the guideline.
Also it would be really beneficial to add a little description to some of the links for an easier navigation.
Oh, and btw, I can't find the PR you reviewed yourself as needed.

@cvyl
Copy link
Author

cvyl commented Oct 28, 2024

@sindresorhus @menisadi, I have updated the README with the changes that were requested. Please review the modifications at your convenience. Thank you very much for your time and consideration.

https://github.com/cvyl/awesome-transgender

@cvyl
Copy link
Author

cvyl commented Oct 29, 2024

I've resolved the listing to the newest commit.

@menisadi
Copy link

Great. Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants