Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Textpattern #769

Merged
merged 3 commits into from
Nov 4, 2016
Merged

Add Textpattern #769

merged 3 commits into from
Nov 4, 2016

Conversation

drmonkeyninja
Copy link
Contributor

@drmonkeyninja drmonkeyninja commented Sep 20, 2016

https://github.com/drmonkeyninja/awesome-textpattern

This is the awesome list for the Textpattern CMS and has been around for well over a year now. The list uses Textile instead of Markdown, but this is because Textile is the default markup syntax used by the Textpattern community and so was chosen to encourage participation.

  • I have read and understood the contribution guidelines and the instructions for creating a list.
  • This pull request has a descriptive title. (For example: Add Node.js)
  • The list I added
    • has been around for at least 20 days,
    • is a non-generated Markdown file in a GitHub repo,
    • is not a duplicate,
    • only has awesome items with descriptions (Awesome lists are curations of the best, not of everything),
    • contains the awesome badge on the right side of the list heading,
    • has a Table of Contents section named Contents as the first section,
    • has an appropriate license (Meaning something like CC0, NOT a code licence like MIT, BSD, Apache, etc),
    • has contribution guidelines,
    • has been checked for inconsistent formatting, spelling, and grammar (This includes starting each link description with an uppercase character and ending it with a period ., and consistent naming),
    • has been added at the bottom of the appropriate category.

@davisonio
Copy link
Contributor

has a Table of Contents section named Contents as the first section,

Not done.

is a non-generated Markdown file in a GitHub repo,

Any reason for not using markdown? We prefer markdown as it's much easier to use and can mean that new contributors to awesome lists can get editing right away without learning complicated syntax.

@sindresorhus
Copy link
Owner

Don't use the en-dash between link and description. It's not meant for that purpose.

I would like to see more than just plugins. Include some blog posts, tutorials, links to community resources (Example: https://github.com/sindresorhus/awesome-electron#community), videos of talks, book, learning material, etc.

@drmonkeyninja
Copy link
Contributor Author

@davisonio I've updated the 'Table of Contents' to just 'Contents', I'd missed that one when submitting this as I've been maintaining Awesome Textpattern for a while now and at the time the other Awesome lists all seemed to use 'Table of Contents' (and still do).

As for the use of Textile over Markdown the reasoning is basically the same as yours for using Markdown for the Awesome lists. Markdown isn't commonly used by the Textpattern community as the Textpattern CMS has always used Textile as it's main markup syntax and so is more familiar to its users. Switching the list to Markdown would add a barrier to Textpattern users to contributing to it and I'd rather make it easy for others from the CMS's community contribute to it.

@sindresorhus the en-dash is an unfortunate side effect of using Textile due to the way it gets rendered. As for non-plugin resources there are already a few listed but I've added a Community section and asked the Textpattern community to help expand this.

@sindresorhus
Copy link
Owner

sindresorhus commented Oct 20, 2016

Regarding use of Textile, makes sense.

I do like to see more blog posts, tutorials, videos of talks, book, learning material, etc, being added though. Here's an example of how it's done: https://github.com/sindresorhus/awesome-electron#documentation

  • I would drop the inspired by the awesome-php idea. part. You can rather link to that list in a Related section at the bottom.
  • the default theme => The default theme.

The merge conflict also needs fixing.

@@ -367,6 +367,7 @@ Check out my [blog](https://blog.sindresorhus.com) and follow me on [Twitter](ht

- [Umbraco](https://github.com/leekelleher/awesome-umbraco)
- [Refinery CMS](https://github.com/refinerycms-contrib/awesome-refinerycms)
- [Textpattern](https://github.com/drmonkeyninja/awesome-textpattern)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a succinct description about what Textpattern is here. See other description on how to format it.

@drmonkeyninja
Copy link
Contributor Author

@sindresorhus I've fixed the merge conflict and added a description. I've also fixed those issues with Awesome Textpattern. 😀

@sindresorhus sindresorhus merged commit 69ca5c7 into sindresorhus:master Nov 4, 2016
sindresorhus pushed a commit that referenced this pull request Nov 4, 2016
@sindresorhus
Copy link
Owner

Landed :)

Noticed a couple of more things now though:

  • Include project logo in the top right, like e.g. https://github.com/sindresorhus/awesome-electron (The logo should link to the project website) (The logo should be high-DPI, set it to minimum half the width of the original image)
  • There should be a succinct summary at the top about the project.

@drmonkeyninja
Copy link
Contributor Author

Thanks @sindresorhus. I'll look into getting those further points sorted. 😃

parinck pushed a commit to parinck/awesome that referenced this pull request Jul 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants