Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Frege #782

Merged
merged 2 commits into from
Oct 8, 2016
Merged

Add Frege #782

merged 2 commits into from
Oct 8, 2016

Conversation

sfischer13
Copy link
Contributor

https://github.com/sfischer13/awesome-frege

This list is about Frege, a Haskell for the JVM. It contains awesome resources for Frege developers.

  • I have read and understood the contribution guidelines and the instructions for creating a list.
  • This pull request has a descriptive title. (For example: Add Node.js)
  • The list I added
    • has been around for at least 20 days,
    • is a non-generated Markdown file in a GitHub repo,
    • is not a duplicate,
    • only has awesome items with descriptions (Awesome lists are curations of the best, not of everything),
    • contains the awesome badge on the right side of the list heading,
    • has a Table of Contents section named Contents as the first section,
    • has an appropriate license (Meaning something like CC0, NOT a code licence like MIT, BSD, Apache, etc),
    • has contribution guidelines,
    • has been checked for inconsistent formatting, spelling, and grammar (This includes starting each link description with an uppercase character and ending it with a period ., and consistent naming),
    • has been added at the bottom of the appropriate category.

@sindresorhus
Copy link
Owner

Feedback:

  • Drop the Inspired by the awesome list thing. text.
  • Drop the Travis status badge. It has no practical purpose there.
  • The contributing guidelines should also include the expected formatting. See contributing.md in this repo.
  • Include project logo in the top right, like e.g. https://github.com/sindresorhus/awesome-electron (The logo should link to the project website) (The logo should be high-DPI, set it to minimum half the width of the original image)
  • Drop all the A / An prefixes in the descriptions.
  • In the description at the top, A curated list of awesome resources for the Frege programming language., linkify Frege to https://en.wikipedia.org/wiki/Frege_(programming_language)

sindresorhus
sindresorhus requested changes Oct 6, 2016
View reviewed changes
readme.md
@@ -127,6 +127,7 @@ Check out my [blog](https://blog.sindresorhus.com) and follow me on [Twitter](ht
- [AutoIt](https://github.com/J2TeaM/awesome-AutoIt)
- [Crystal](https://github.com/veelenga/awesome-crystal)
- [TypeScript](https://github.com/dzharii/awesome-typescript)
- [Frege](https://github.com/sfischer13/awesome-frege)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a succinct description. See other entries with description on how to format it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed feedback! I'm working on the changes.

@sindresorhus sindresorhus changed the title Add Frege programming language programming language Oct 6, 2016
@sindresorhus sindresorhus changed the title programming language Add Frege Oct 6, 2016
@sfischer13
Copy link
Contributor Author

sfischer13 commented Oct 7, 2016 •
edited
Loading

  • Drop the Inspired by the awesome list thing. text.
  • Drop the Travis status badge. It has no practical purpose there.
  • The contributing guidelines should also include the expected formatting.
  • Include project logo in the top right.
  • Drop all the A / An prefixes in the descriptions.
  • In the description at the top, linkify Frege.
  • Add a succinct description.

@sfischer13 sfischer13 closed this Oct 7, 2016
@sfischer13 sfischer13 reopened this Oct 7, 2016
@sfischer13
Copy link
Contributor Author

OK, everything should be fixed now.

@sindresorhus sindresorhus merged commit 7216eaa into sindresorhus:master Oct 8, 2016
@sindresorhus
Copy link
Owner

👌✨

@sfischer13
Copy link
Contributor Author

Thanks again for your effort and for creating this cool project!

heynickc added a commit to heynickc/awesome that referenced this pull request Oct 17, 2016
@heynickc
Merge remote-tracking branch 'upstream/master'
6db325c 
* upstream/master:
  add a description to "Git Add-ons" (sindresorhus#799)
  Add CMake (sindresorhus#779)
  Add Raspberry Pi (sindresorhus#770)
  Add Frege (sindresorhus#782)
  Update Awesome Hyperterm to Awesome Hyper (sindresorhus#785)
  Add Wagtail (sindresorhus#777)
  Add Falsehood (sindresorhus#774)
  Add Webpack (sindresorhus#751)
  Pluralize title of CMS section (sindresorhus#776)
parinck pushed a commit to parinck/awesome that referenced this pull request Jul 23, 2017
@sfischer13 @parinck
Add Frege (sindresorhus#782)
b4dcd4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfischer13 @sindresorhus