Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Alfred Workflows #811

Merged
merged 6 commits into from
Nov 3, 2016
Merged

Add Alfred Workflows #811

merged 6 commits into from
Nov 3, 2016

Conversation

derimagia
Copy link
Contributor

https://github.com/derimagia/awesome-alfred-workflows

Workflows for Alfred on macOS.

  • I have read and understood the contribution guidelines and the instructions for creating a list.
  • This pull request has a descriptive title. (For example: Add Node.js)
  • The list I added
    • has been around for at least 20 days,
    • is a non-generated Markdown file in a GitHub repo,
    • is not a duplicate,
    • only has awesome items with descriptions (Awesome lists are curations of the best, not of everything),
    • contains the awesome badge on the right side of the list heading,
    • has a Table of Contents section named Contents as the first section,
    • has an appropriate license (Meaning something like CC0, NOT a code licence like MIT, BSD, Apache, etc),
    • has contribution guidelines,
    • has been checked for inconsistent formatting, spelling, and grammar (This includes starting each link description with an uppercase character and ending it with a period ., and consistent naming),
    • has been added at the bottom of the appropriate category.

@sindresorhus
Copy link
Owner

Feedback:

  • NodeJS => Node.js
  • There should be a succinct summary at the top about what Alfred is and linkify the name to its website.
  • Ensure all your links works. I found that the SSH entry didn't work.
  • Use the SVG version of the CC0 license badge.

sindresorhus
sindresorhus requested changes Nov 3, 2016
View reviewed changes
readme.md
@@ -457,6 +457,7 @@ Check out my [blog](https://blog.sindresorhus.com) and follow me on [Twitter](ht
- [ChatOps](https://github.com/exAspArk/awesome-chatops) - Managing technical and business operations through a chat.
- [Falsehood](https://github.com/kdeldycke/awesome-falsehood) - Falsehoods programmers believe in.
- [Domain-Driven Design](https://github.com/heynickc/awesome-ddd) - Software development approach for complex needs by connecting the implementation to an evolving model.
- [Alfred Workflows](https://github.com/derimagia/awesome-alfred-workflows)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have a succinct description of what Alfred is. See the above description on how to format it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, should this be in the default pull request template? I saw it but a lot of them that should have it didn't so I wasn't sure. Thanks for the review!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be in the default pull request template?

Yes, I have a lot of updates to it, but haven't gotten around to it yet.

@derimagia
Copy link
Contributor Author

Thanks, Updated!

@derimagia
Copy link
Contributor Author

Sorry - haven't messed with the Pull request system in Github much. I still see it set to "Changes requested", so I have to set this or is this just a status you set on your end?

sindresorhus
sindresorhus reviewed Nov 3, 2016
View reviewed changes
readme.md
@@ -457,6 +457,7 @@ Check out my [blog](https://blog.sindresorhus.com) and follow me on [Twitter](ht
- [ChatOps](https://github.com/exAspArk/awesome-chatops) - Managing technical and business operations through a chat.
- [Falsehood](https://github.com/kdeldycke/awesome-falsehood) - Falsehoods programmers believe in.
- [Domain-Driven Design](https://github.com/heynickc/awesome-ddd) - Software development approach for complex needs by connecting the implementation to an evolving model.
- [Alfred Workflows](https://github.com/derimagia/awesome-alfred-workflows) - Workflows for Alfred, the productivity application for Mac OS X that boosts your efficiency with hotkeys, keywords and text expansion.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not succinct. Succinct means short and clear.

It's also not Mac OS X, but macOS.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflows for Alfred is moot as it's already the title.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly copied it from their site but I get your point for the list. Reason for "Workflows for Alfred" was since the description that needs to be there isn't as much for workflows but for alfred but I see that was silly. Sorry about that.

I updated the description.

sindresorhus
sindresorhus requested changes Nov 3, 2016
View reviewed changes
readme.md
@@ -457,6 +457,7 @@ Check out my [blog](https://blog.sindresorhus.com) and follow me on [Twitter](ht
- [ChatOps](https://github.com/exAspArk/awesome-chatops) - Managing technical and business operations through a chat.
- [Falsehood](https://github.com/kdeldycke/awesome-falsehood) - Falsehoods programmers believe in.
- [Domain-Driven Design](https://github.com/heynickc/awesome-ddd) - Software development approach for complex needs by connecting the implementation to an evolving model.
- [Alfred Workflows](https://github.com/derimagia/awesome-alfred-workflows) - Productivity application for Mac OS X.
Copy link
Owner

@sindresorhus sindresorhus Nov 3, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already commented in #811 (comment).

It's not Mac OS X, but macOS.

application => app

@sindresorhus
Copy link
Owner

You need to fix the merge conflict. (That does not mean opening a new PR).

@derimagia
Copy link
Contributor Author

That's what I get for copying the description from Alfred's Site - anyway merge conflict fixed.

@sindresorhus
Copy link
Owner

NodeJS => Node.js

Not correctly fixed.

There should be a succinct summary at the top about what Alfred is and linkify the name to its website.

Please read this again. Not correctly fixed. Also need updating with the same feedback as here.

Ensure all your links works. I found that the SSH entry didn't work.

Not fixed.

@derimagia
Copy link
Contributor Author

s/Node.JS/Node.js/ done, Reworded but it's a little longer than here since it explains what workflows are.

ssh entry was already fixed. I changed the path instead of getting rid of it. Also checked other pages for broken links. I just re-looked at it and saw a better link to link to, though.

@sindresorhus sindresorhus merged commit 8a29c8e into sindresorhus:master Nov 3, 2016
@derimagia
Copy link
Contributor Author

Thanks for being so picky by the way - even though most of these were flat out an error on my part. It shows in the quality of your projects.

@sindresorhus
Copy link
Owner

Thanks for being so responsive :)

parinck pushed a commit to parinck/awesome that referenced this pull request Jul 23, 2017
@derimagia @parinck
Add Alfred Workflows (sindresorhus#811)
1983b3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derimagia @sindresorhus