Code refactoring

[Caesarovich]

This PR has for objective to provide a little code refactoring in order to make the library more easily maintainable/scalable/readable.
Effectively the main function of the library was around 150 lines long and it renders it really hard to read/understand.

So I decided to divide it a little, now the code is separated into two 'main functions' :

• The main function from before without the content handling part.
• And the makeContentText function wich now handles the whole content part.

This new function takes in 4 arguments:

• text: wich is the box's content text provided by the user
• padding: the optional padding desired
• columns: the maximum column count the content should take
• align: the optional text alignment

This allows for more flexibility regarding the width of the content. It'll allow an easy implementation for issue #51. (PR coming soon). Also the way this function is done/used fixes #53 and all kind of similar bugs where the box would exceed the terminal's size. See images below:

This pretty much sums up the purpose of this PR. It's kind of a preparation for other PRs I'm preparing

---

Fixes #53

[sindresorhus]

Remove outdated tests that aren't relevant anymore

Why are the tests not relevant anymore?

[sindresorhus]

Also the way this function is done/used fixes #53 and all kind of similar bugs where the box would exceed the terminal's size.

Would be nice to have tests for this.

[Caesarovich]

Remove outdated tests that aren't relevant anymore

Why are the tests not relevant anymore?

Those tests were expecting results that do not accord with the fact that the boxes shouldn't overflow the terminal.

I found that by investigating those and try running them in a separate script. I observed that the test produced a box exceeding the terminal's size and accounting it as Ok, while accounting the new version (The one that doesn't overflow anymore) as Ko.
It's due to the fact that the new way of doing the box I implemented works very differently than before in some ways, like cutting the text into newlines to not overflow, etc...

[Caesarovich]

Also the way this function is done/used fixes #53 and all kind of similar bugs where the box would exceed the terminal's size.

Would be nice to have tests for this.

This is a very good idea, I'll get to it.

[Caesarovich]

Changes done, waiting for your review 👍

[sindresorhus]

Those tests were expecting results that do not accord with the fact that the boxes shouldn't overflow the terminal.

Wouldn't it be better to adjust the tests instead of removing them?

[Caesarovich]

Changes done, waiting for your review

Those tests were expecting results that do not accord with the fact that the boxes shouldn't overflow the terminal.

Wouldn't it be better to adjust the tests instead of removing them?

I can do it. Tho the it is now equivalent as combining the 'align option' tests with the new 'overflow' test. If anything, one one these two would already Ko before.

I'll push it in the next minutes.

[Caesarovich]

Readapted the tests. I pushed the changes. 👌

[sindresorhus]

Looks good now. Thanks :)