Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Upgrade broccoli-persistent-filter to v3 #20

Merged

Conversation

nlfurniss
Copy link
Contributor

@nlfurniss nlfurniss commented Sep 9, 2020

Upgrade broccoli-persistent-filter for increased performance.

Also

  • moved Node support to the current maintenance version
  • fixed eslint errors

Copy link
Collaborator

@stefanpenner stefanpenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions:

  • this is a breaking change, so I assume it is ok if I release this with a major version bump?
  • would this benefit from parallel builds as well?

index.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@nlfurniss
Copy link
Contributor Author

  • this is a breaking change, so I assume it is ok if I release this with a major version bump?

yup!

  • would this benefit from parallel builds as well?

I do not know, but googling ember cli parallel build didn't yield anything useful...

@stefanpenner
Copy link
Collaborator

would this benefit from parallel builds as well?
I do not know, but googling ember cli parallel build didn't yield anything useful...

Basically, if each "processString" in a broccoli-persisitent filter subclass, is entirely independent of the other, and if each one is CPU limited and sufficiently slow, we can actually run them in parallel via node worker_threads or sub-processes.

This doesn't block this PR at all, but I wanted to see if this is important as it could yield an improvement if it is common for autoprefixer to be given many individual files, and the processing itself is CPU bound.

If that sounds like a fit, it may be worth a future effort to make this part parallel. Let me know.

@stefanpenner
Copy link
Collaborator

this is a breaking change, so I assume it is ok if I release this with a major version bump?
yup!

Thanks for the confirmation.

index.js Outdated Show resolved Hide resolved
@stefanpenner stefanpenner merged commit b9cbfbf into sindresorhus:master Sep 17, 2020
@nlfurniss nlfurniss deleted the update-broc-persistent-filter branch October 6, 2020 01:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants