Apply casing to chars except the ones after a number (issue #77) #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
Based on this issue #77
If understood correctly, what's needed is for strings' characters to change to lower case or upper case only if they are not after a number. For example:
camelCase('Textures_3d') // -> textures3dcamelCase('Textures_3D') // -> textures3DcamelCase('textures_3d', {pascalCase: true}) // -> Textures3dcamelCase('textures_3D, {pascalCase: true}') // -> Textures3DChars after numbers do not change
index.js
Created a helper function called applyCasingExceptAfterNumber, which is responsible to apply case functions to all chars except the ones after a number. It takes as parameters the string, and the case function.
test.js
Updated 6 tests in order for the new desired effect to be the correct one
package.json
Update the xo dependency version in order for tests to run due to a bug presented in previous xojs/xo versions