Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icon on Linux #1343

Closed
wants to merge 1 commit into from
Closed

Conversation

BananaManCJ
Copy link

No description provided.

@BananaManCJ
Copy link
Author

Fixes #1213

@BananaManCJ BananaManCJ changed the title Added icon sizes Fix icon on Linux Apr 25, 2020
@sindresorhus
Copy link
Owner

This should be fixed in electron-builder, not here.

@BananaManCJ
Copy link
Author

This tells the electron builder what size the icon is, and since the size wasn't specified before, it defaulted to 0x0, making the icon unable to be used.

@sindresorhus
Copy link
Owner

electron-builder documents that it is able to generate all the needed icons from one file.

@BananaManCJ
Copy link
Author

Closing pull request since this is allegedly is fixed with this commit

@BananaManCJ
Copy link
Author

@CvX
Copy link
Collaborator

CvX commented Apr 30, 2020

@BananaManCJ that's just a commit to some other app.

@BananaManCJ
Copy link
Author

@BananaManCJ that's just a commit to some other app.

I know, but that is the way to fix it on this app. I was quoting that comment to show how to fix it on this repo.

@yermulnik
Copy link

There's a somewhat related PR in Electron that has been merged today: electron/electron#23674

@BananaManCJ
Copy link
Author

There's a somewhat related PR in Electron that has been merged today: electron/electron#23674

That's for system tray icons, not the icon used in the .desktop file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants