-
-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix icon on Linux #1343
Fix icon on Linux #1343
Conversation
Fixes #1213 |
This should be fixed in electron-builder, not here. |
This tells the electron builder what size the icon is, and since the size wasn't specified before, it defaulted to 0x0, making the icon unable to be used. |
electron-builder documents that it is able to generate all the needed icons from one file. |
Closing pull request since this is allegedly is fixed with this commit |
@BananaManCJ that's just a commit to some other app. |
I know, but that is the way to fix it on this app. I was quoting that comment to show how to fix it on this repo. |
There's a somewhat related PR in Electron that has been merged today: electron/electron#23674 |
That's for system tray icons, not the icon used in the .desktop file |
No description provided.