Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the fullPage option #58

Open
sindresorhus opened this issue Oct 16, 2020 · 1 comment
Open

Fix the fullPage option #58

sindresorhus opened this issue Oct 16, 2020 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@sindresorhus
Copy link
Owner

It's currently broken. Anyone wanting to work on this can continue where #49 left off.
@sindresorhus sindresorhus added bug Something isn't working help wanted Extra attention is needed labels Oct 16, 2020
This was referenced Oct 17, 2020
Closed
Closed
sindresorhus added a commit that referenced this issue Oct 17, 2020
@sindresorhus
Temporary fix for the fullPage option
e52c58f 
Fixes #55

See #58
@ghost
Copy link

ghost commented Nov 5, 2020 •
edited by ghost
Loading

Points to fix:

  • incorrect value used (click)
  • scroll the page 'inside the browser' (click) - we are holding a values of window height that may (or may not) change during page scrolling (that's why CLS was introduced)
  • change line so it waits for all images to finish loading but also will resolve the awaited promise with after timeoutInSeconds of waiting so we do not wait forever

Fixing those should be a proper solution.

@sindresorhus sindresorhus mentioned this issue Nov 20, 2020
Closed
@brandon93s brandon93s mentioned this issue Nov 25, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sindresorhus