Improve browser compatibility #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
changed the title
silverwind
reviewed
Jul 31, 2019
| @@ -3,7 +3,7 @@ const os = require('os'); | |||
|
|
|||
| const extractPathRegex = /\s+at.*(?:\(|\s)(.*)\)?/; | |||
| const pathRegex = /^(?:(?:(?:node|(?:internal\/[\w/]*|.*node_modules\/(?:babel-polyfill|pirates)\/.*)?\w+)\.js:\d+:\d+)|native)/; | |||
| const homeDir = os.homedir(); | |||
| const homeDir = typeof os.homedir === 'undefined' ? '' : os.homedir(); | |||
There was a problem hiding this comment.
Isn't this a ReferenceError when os is not a object?
There was a problem hiding this comment.
os should be an empty object when browser.os = false in package.json
There was a problem hiding this comment.
Indeed, I see it in https://github.com/defunctzombie/package-browser-field-spec#ignore-a-module. It's rather confusing that the value is to be set to false instead of something more sane like {}.
There was a problem hiding this comment.
I could still see it throwing that error for implementations that don't read package.json, for example when a browser loads the file via <script type="module">, so I'd advice changing this line to:
os && typeof os.homedir === 'undefined' ? '' : os.homedir();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6 as @sindresorhus suggested in #13 (comment)