Make basePath option support file:// URLs and ignore trailing slash #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
force-pushed
the
fileurl-basepath
branch
2 times, most recently
from
bc233df to
9e5a49e
Compare
- Make the `basePath` option transform file URLs into relative paths as well. - Make the `basePath` option ignore trailing slash. - Refactor tests to use template strings where possible.
silverwind
force-pushed
the
fileurl-basepath
branch
from
9e5a49e to
6327a70
Compare
silverwind
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basePathoption transform file URLs into relative paths as well.basePathoption ignore trailing slash.