feat: replace buffer with uint8array #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Oct 24, 2023
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
|
I see that the checks for Node.js 14 are failing. Looking at the error it seems that the non compatible code comes from the |
|
Thanks :) |
I'm going to require Node.js 18. |
Eneris
pushed a commit
to Eneris/conf
that referenced
this pull request
Dec 6, 2023
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com> (cherry picked from commit ddcfa1d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188
This PR replaces usage of
Bufferin favor ofUint8Array. This is done by taking a dependency on theuint8array-extraspackage.I verified that the tests are passing locally and I have update the documentation in the docstrings & README file.