Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: store failing validation after schema change #194

Merged
merged 2 commits into from
Jun 22, 2024
Merged

fix: store failing validation after schema change #194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74fe4c2
fix: store failing validation after schema change
dopry Jun 21, 2024
f3aa0ed
Update index.ts
sindresorhus Jun 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions source/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,16 @@ export default class Conf<T extends Record<string, any> = Record<string, unknown

const fileStore = this.store;
const store = Object.assign(createPlainObject(), options.defaults, fileStore);

if (options.migrations) {
if (!options.projectVersion) {
throw new Error('Please specify the `projectVersion` option.');
}

this._migrate(options.migrations, options.projectVersion, options.beforeEachMigration);
}

// We defer validation until after migrations are applied so that the store can be updated to the current schema.
this._validate(store);

try {
Expand All @@ -148,14 +158,6 @@ export default class Conf<T extends Record<string, any> = Record<string, unknown
if (options.watch) {
this._watch();
}

if (options.migrations) {
if (!options.projectVersion) {
throw new Error('Please specify the `projectVersion` option.');
}

this._migrate(options.migrations, options.projectVersion, options.beforeEachMigration);
}
}

/**
Expand Down