Conditionally stop doing the chmod stuff

[sindresorhus]

Note libuv/libuv@eaf25ae and https://github.com/nodejs/node/pull/15745/files#diff-194c5460fc6f1d425ebb0ae0270ead06R11

I don't think we can feature test this, so we can just do a Node.js version test.

(It's not out in a Node.js version yet, so no rush)

// @kevva

---

IssueHunt Summary

stroncium has been rewarded.

Backers (Total: $40.00)

• issuehunt ($40.00)

Submitted pull Requests

• #39 Stop preserving ownership, stop performing chmod after copyFileSync, solves #22

---

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

---

IssueHunt has been backed by the following sponsors. Become a sponsor

[kevva]

Cool! Will keep an eye on it and add support for when available.

[sindresorhus]

We can now do this without a Node.js version check. We should add a tests to ensure chmod is still being done though.

We should also look into whether we can remove the fs.chownSync call, and if not, open an issue on Node.js whether fs.copyFile() could have an option to do this natively.

[IssueHuntBot]

@issuehunt has funded $40.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[stroncium]

Should there even be chown in the first place? It's non-conventional and kinda counter-intuitive as it doesn't match behavior of any traditional utilities(as far as I know). (For that reason I don't think there is any point expecting it to be implemented as part of copyFile.)

But what's more:

• in linux it only works when you are root
• in macos, I'm not exactly sure, but should be same as in linux
• in windows, as far as I understand, chown is a no-op

If it is indeed needed, I can add a check if we're root for linux and macos(if my assumption is correct), and just get rid of it under windows.

Note: it actually throws error(unless root), but it's captured by graceful-fs.

[sindresorhus]

@stroncium It was added in 22ef37b to preserve ownership of the file. I'm not that well-versed in chown, so I trust your judgement more. Let's remove it.

[stroncium]

@sindresorhus If we put it the way it was described in #16(which was solved by 22ef37b) as mirroring cp -a mode, it does work correctly at the moment.

I'm just pointing out that normally the ownership part doesn't even work(because you have to be root for that, mentioned cp -a just silently ignores that part if you aren't), and most people wouldn't even know you could do that with cp, and definitely won't expect it to be default.

It's more or less political choice at the moment, as it is undocumented quirk, and my vote is for removing ownership preservation part(leaving mode preservation as it is), but it would be really good to have at least one more opinion on that.

[sindresorhus]

Let's just remove it and see if anyone complains. We can explicitly document that only mode is preserved, not ownership.

[issuehunt-oss]

@sindresorhus has rewarded $36.00 to @stroncium. See it on IssueHunt

• 💰 Total deposit: $40.00
• 🎉 Repository reward(0%): $0.00
• 🔧 Service fee(10%): $4.00