Require Node.js 8, detect read IO errors after open #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Drop pify in favor of util.promisify * Use p-event to promisify streams * Drop copySyncFallback and all related code * Remove `default` export per TODO comments
coreyfarrell
commented
Apr 12, 2019
|
Hmm, this is failing on macOS: https://travis-ci.org/sindresorhus/cp-file/jobs/522134757 |
|
I remember having an issue with EACCES testing outside linux on another package, can't quite remember where though (I'm pretty sure it was one of your packages though). I'll look at my PR history see if I can find it. |
|
@sindresorhus https://github.com/sindresorhus/path-type/pull/3/files#diff-6624e890b4dd46cf165d3bc6591ee9c0 - looks like I just hijacked |
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sindresorhus if you prefer I can drop the second commit from this PR, resubmit separately if/when the first is merged. First commit upgrades everything to the node.js 8 way (technically this requires node.js 8.5 for fs.copyFileSync).
Second commit addresses the existing issue where read IO errors after open were not processed. In addition to the automated test I manually tested by unplugging a USB drive in the middle of copying a Linux distro ISO from it (that's where I got the exact EIO error used in testing). If you don't want the first commit then @Henry128 can probably just copy my test into #31.
Fixes #30
Closes #31