-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to clear timer #10
Conversation
Hi, please add some tests for this feature, so I can merge your PR :). |
Done. I added both a basic clear link as well as a link to trigger the event immediately and clear the timer at the same time (trivial but this was the real use case I wanted to add the feature for, so it seemed good to demonstrate). |
Thanks! |
Just came across this Thanks :) |
@nathanbuchar I'm afraid I don't have the npm publish rights on this package. |
@jonathanong hi? |
Any progress on this? :\ |
i don't have access either. seems like you have to ask @TooTallNate |
You don't? Isn't jongleberry yours? |
Or do you mean owner access |
oh crap i was reading it wrong. who am i giving access to? |
We just need this change to be pushed to npm is all :) |
@jonathanong you can add me&I'll push it. |
@nathanbuchar btw, if you're using |
Any updates on this? I'd love to be able to use the new clear feature on the npm version. |
@TooTallNate are there any plans to update the npm package to release 1.0.1 which includes this fix? |
Still waiting for this to be published :\… |
This pull request adds a property to the function returned by debounce which can be called to clear the timer and prevent scheduled future executions. It addresses #9 which I did not write but I did need the same functionality.