Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support progressive reporting #141

Merged
merged 9 commits into from
May 16, 2022
Merged

Support progressive reporting #141

merged 9 commits into from
May 16, 2022

Conversation

jopemachine
Copy link
Contributor

Fixes #133.

Implemented progressive reporting by referring https://github.com/sindresorhus/cpy#progress-reporting.

@jopemachine
Copy link
Contributor Author

The test seems failed on Windows due to this issue

@sindresorhus
Copy link
Owner

I no longer think attaching properties to a promise is the right approach. I think it's better to do a onProgress option.

test.js Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
test.js Outdated Show resolved Hide resolved
test.js Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add progress event
2 participants