Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
del makes use of the
globby
package which takes a list of globs as parameter and returns a promise with the list of valid patterns.So, with this directory tree:
The code
globby(['/bar', '/foo']) would return
['/foo']`.So calling del(['/bar', '/foo']) would simply delete
/foo
and return `['/foo'] without any error.While calling
del(['access_denied', '/foo'])
would reject the promise with a permission error, but/foo
would have been deleted and there's no way to know it.This pull_request attempts to make error handling more consistent, so both previous calls would return
['/foo']
so the developer can find if there was an error by comparing the original array and the returned array's length.