Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass options to rimraf #97

Closed

Conversation

chrisblossom
Copy link
Contributor

I've wanted to add options to rimraf but haven't been able to.

This also defaults to use graceful-fs to help prevent various fs errors. If this isn't wanted I can remove it.

@sindresorhus
Copy link
Owner

What do you need those options for? Actual use-cases? I have intentionally omitted them as I never saw the point and wanted to keep this module as simple as possible.

@chrisblossom
Copy link
Contributor Author

I’ve encountered several errors on appveyor CI that would have been fixed if I could increase the limits and use graceful-fs instead of retrying the build.

@sindresorhus
Copy link
Owner

I'm happy to use graceful-fs here. That would solve your problem so we don't need to expose all these options, right?

@chrisblossom
Copy link
Contributor Author

Another use-case would be to set custom sync functions that would "sync-back-off" to solve sync emfileWait / maxBusyTries. (Probably not a good idea for all use-cases (web-server), but others (webpack build) it would be nice). I'd probably experiment with this with clean-webpack-plugin.

That would solve your problem so we don't need to expose all these options, right?

I'm not 100% sure, but definitely is a good place to start.

When I was originally putting the PR in, I just wanted to be able to set the maxBusyTries and emfileWait options and graceful-fs so I figured I'd put all options available in and go from there.

Should I close this and add a new PR that just adds graceful-fs?

@sindresorhus
Copy link
Owner

When I was originally putting the PR in, I just wanted to be able to set the maxBusyTries and emfileWait options and graceful-fs so I figured I'd put all options available in and go from there.

Instead of exposing a gadzillion options, I would prefer to first try to improve the defaults instead, if needed.

Should I close this and add a new PR that just adds graceful-fs?

👍

@chrisblossom chrisblossom mentioned this pull request Aug 22, 2019
@chrisblossom
Copy link
Contributor Author

Closing in favor of #108.

@chrisblossom chrisblossom deleted the pass-options-to-rimraf branch August 22, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants