Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add change event using polling #8

Merged
merged 5 commits into from
Jun 29, 2019

Conversation

whitecrownclown
Copy link
Contributor

Relates to sindresorhus/caprine#760

@sindresorhus Added polling implementation including readme and test updates. Please have a look!

@whitecrownclown whitecrownclown force-pushed the feat/on-change branch 3 times, most recently from f44b1e3 to 05cad99 Compare June 19, 2019 09:27
@sindresorhus
Copy link
Owner

I don't think there should be public methods for startPolling and stopPolling. It should poll if any events are listening for change, and if not it should stop polling.

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@sindresorhus sindresorhus changed the title Add change event with polling implementation Add change event using polling Jun 29, 2019
@sindresorhus sindresorhus merged commit b596760 into sindresorhus:master Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants