Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update prefer-optional-catch-binding fixer #1021

Closed
wants to merge 1 commit into from
Closed

Update prefer-optional-catch-binding fixer #1021

wants to merge 1 commit into from

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Jan 15, 2021

Update to use utility added in #1020, previously we remove spaces after catch parameter, now remove spaces before it.

@fisker fisker marked this pull request as draft January 15, 2021 03:18
@fisker fisker force-pushed the prefer-optional-catch-binding branch from 55b7173 to 3fe5020 Compare January 15, 2021 03:18
@fisker
Copy link
Collaborator Author

fisker commented Jan 15, 2021 •
edited
Loading

Hold this due to possible bug in eslint-utils mysticatea/eslint-utils#15

Base automatically changed from master to main January 23, 2021 11:04
@sindresorhus
Copy link
Owner

There has not been any activity on mysticatea/eslint-utils#15 for a year. Maybe we should just fork it?

Or maybe @mysticatea would be willing to give us commit access?

@fisker
Copy link
Collaborator Author

fisker commented Mar 16, 2021 •
edited
Loading

Let's close this, it's not fixing anything, just whitespace, not important.

@fisker fisker closed this Mar 16, 2021
@fisker fisker deleted the prefer-optional-catch-binding branch March 16, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fisker @sindresorhus