Update ESLint to v7

[fisker]

Prepare for ESLint 7

Closes #368

[fisker]

 AssertionError {
    actual: false,
    code: 'ERR_ASSERTION',
    expected: true,
    generatedMessage: false,
    operator: '==',
    message: 'Invalid error property name \'ruleId\'. Expected one of [\'message\', \'messageId\', \'data\', \'type\', \'line\', \'column\', \'endLine\', \'endColumn\', \'suggestions\'].',
  }

This is a breaking change eslint/eslint#12096 , should we remove them all? But this issue is trying to enforce it

[sindresorhus]

I guess we should use messageId instead?

[fisker]

I use messageId and data for few rules in my recent PRs, but I feel it's not safe, I missed data in #635 .

So I add extra tests in this PR https://github.com/sindresorhus/eslint-plugin-unicorn/pull/666/files#diff-01ad3bc5b5ffd5a28466a36319461266R209

[fisker]

Updating to v7.0.0

[brettz9]

Could we get a new release including this commit?

When using ESLint 7, I'm getting an error blocking reporting of all other linting errors:

context.report() called with a messageId of 'unexpectedComment' which is not present in the 'messages' config

I note that this unexpectedComment message is not present in eslint-plugin-unicorn but is present in the no-warning-comments rule from ESLint 7 which the expiring-todo-comments rule requires. I think this PR should have fixed the issue, but was wondering if we could get a new release. Thanks!

[fisker]

@brettz9
This error already fixed in #668 v19.0.0 should include that code. Are you sure you are using latest version?

[brettz9]

Ugh, apologies for the wasted time. No, I need to adjust, thank you!!

[fisker]

No need apologies, glad I did that before ESLint 7 release.