Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve string-content #637

Merged
merged 7 commits into from
Mar 30, 2020
Merged

Improve string-content #637

merged 7 commits into from
Mar 30, 2020

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Mar 27, 2020 •
edited
Loading

  • Remove default pattern.
  • Add suggestions to patterns with fix: false
  • Add codecov.yml allow coverage to drop

Fixes #630

@fisker fisker force-pushed the string-content-improve branch from eb27e73 to ad95945 Compare March 27, 2020 06:02
@fisker
Copy link
Collaborator Author

fisker commented Mar 27, 2020 •
edited
Loading

DO NOT MERGE

Just found should test suggestions output.

Done.

sindresorhus
sindresorhus requested changes Mar 30, 2020
View reviewed changes
docs/rules/string-content.md Outdated Show resolved Hide resolved
docs/rules/string-content.md Outdated Show resolved Hide resolved
docs/rules/string-content.md Outdated Show resolved Hide resolved
@fisker @sindresorhus
Apply suggestions from code review
e7b98bc 
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
@sindresorhus sindresorhus merged commit 08fad55 into sindresorhus:master Mar 30, 2020
@fisker fisker deleted the string-content-improve branch March 30, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove string-content default pattern?
2 participants
@fisker @sindresorhus