-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-implement errname resolution #31
Comments
Yes, but we probably shouldn't as they're trying to deprecate it: nodejs/node#2768 I think we should rather open an issue requesting a public API for what we need. |
That is labeled as "stalled", and there are strong arguments for only preventing access to bindings which might be harmful (I doubt an errname lookup would count as harmful, but not sure what else the
Yes, absolutely. In the meantime let's just write a defensive wrapper around Assuming they deprecate before providing a public alternative, we might also be able to extract it from |
#27 dropped execFile in favor of using spawn directly, so we've lost some features.
One is whatever these two lines do:
Can we reliably just do
process.binding('uv')
? Or is that asking for problems. I know it means importing some native lib, but not much beyond that.Maybe we look back all the way to Node
0.12
and make sure it was still imported and used the same back then?The text was updated successfully, but these errors were encountered: