[WIP] stdio option handling #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| t.regex(err.message, /stdout/); | ||
| }); | ||
|
|
||
| test('execa.shell()', async t => { | ||
| const {stdout} = await m.shell('node fixtures/noop foo'); | ||
| const {stdout} = await m.shell('node ../fixtures/noop foo'); |
There was a problem hiding this comment.
Required because: avajs/ava#32 (comment)
|
Is there any way I could take over this PR? Or should @jamestalmage give me write access to his repository? |
|
@SamVerschueren Just create a new branch in this repo, cherrypick his commit, do your changes, and open a new PR. |
|
Closing in favor of #80 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24.
I've only written an options helper method. Not integrated into index.js yet. Started this before #27, and it's backburnered until we get some of the remaining issues from that PR resolved. I'll pick this back up once we've made progress on those.