add tests #48
Merged
add tests #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sindresorhus#34 - Adds some tests for functionality copied from `child_process` in sindresorhus#27. - Normalises the result and error objects further. Each now has `killed`, `signal` and `cmd` properties. - NYC was not ignoring the `fixtures` directory. Fixed that, and configured nyc in package.json instead of via CLI.
|
Travis tests just appear to hang. AVA is not exiting. Works fine locally. |
|
Maybe try adding |
| }); | ||
|
|
||
| // TODO: Should this really be the case, or should we improve on child_process? | ||
| test('err.killed is false if process was killed indirectly', async t => { |
There was a problem hiding this comment.
@sindresorhus - What do you think about this?
Right now, we have this behavior:
cp.kill(); // err.killed will be true
process.kill(cp.pid); // err.killed will be falseThis mimics the behavior of child_process.exec, but it doesn't make a lot of sense to me. If the process is killed, shouldn't killed be true regardless of how it was done?
There was a problem hiding this comment.
I'm with you on this James. If it's killled, it's killed, regardless of how it was done. And if it is killed, jou woild expect that flag to be true.
when 
|
Landing this to unblock work on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34
child_processin Use spawn instead of execFile #27.killed,signalandcmdproperties.fixturesdirectory. Fixed that, and configured nyc in package.json instead of via CLI.