Reimplement missing features. Fixes #30 & #32 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamestalmage
changed the title
|
Yay! Thanks James. Happy xmas and new years :) |
|
Amazing! @sindresorhus can this be released as 0.5.1? ❤️ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27 Removed some helpful stuff.
Timeout option. #30
timeoutOption.This is added back in. The result/error also has a
timedOutmember that will be eithertrueorfalse.reimplement stream cleanup procedures from execFile #32 Cleanup Streams
child_process.spawnhad some cleanup code to ensure streams were destroyed.I'm not sure how to write a meaningful test for this, as I'm not sure how to end a process without the streams also being destroyed for me (I am not sure that cleanup code is even necessary in Node core, I don't see how you get killed without streams destroyed, but I don't think there's any harm in adding back this code just for safety).