Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display single-character percentages on Windows #40

Closed
ehmicky opened this issue Mar 23, 2021 · 2 comments · Fixed by #45
Closed

Display single-character percentages on Windows #40

ehmicky opened this issue Mar 23, 2021 · 2 comments · Fixed by #45

Comments

@ehmicky
Copy link
Collaborator

ehmicky commented Mar 23, 2021

Most percentages single characters are available on Windows CP850. However, this library currently falls back to using ASCII such as 1/3.

Ubuntu 20.10 Gnome terminal:

unix_3

Windows 10 cmd.exe (CP850):

windows_3

However, 1/7, 1/9 and 1/10 are not supported on CP850.

Removing support for those three (arguably not-often-used) characters would allow switching to single characters percentages instead. This would also provide with a more consistent cross-platform experience.

What do you think?

@sindresorhus
Copy link
Owner

Removing support for those three (arguably not-often-used) characters

I don't think we should remove them. Rather just let them keep using the ASCII output. Yes, it will be inconsistent, but as you said, they're not very often used, especially not together.

@ehmicky
Copy link
Collaborator Author

ehmicky commented Mar 24, 2021

Sounds good!
Fixed in #45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants