Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve percentages figures #45

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Improve percentages figures #45

merged 1 commit into from
Mar 24, 2021

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented Mar 24, 2021

Fixes #40.

This improves the figures related to percentages on Windows.

As mentioned in the issue, 1/7, 1/9 and 1/10 are not supported on CP850, so are kept as ASCII.

Ubuntu 20.10 Gnome terminal:

unix_3

Windows 10 cmd.exe (CP850):

windows_3

@sindresorhus sindresorhus changed the title feat: improve percentages figures Improve percentages figures Mar 24, 2021
@sindresorhus sindresorhus merged commit b0a7ef2 into sindresorhus:main Mar 24, 2021
@ehmicky ehmicky deleted the chore/improve-percentages branch March 24, 2021 14:18
@sindresorhus
Copy link
Owner

Are you done with changes? If so, I'm gonna do a new release.

@ehmicky
Copy link
Collaborator Author

ehmicky commented Mar 24, 2021

I have a few more changes coming up today indeed!

@sindresorhus
Copy link
Owner

Ok. Let me know when you're done then 👍

@ehmicky
Copy link
Collaborator Author

ehmicky commented Mar 24, 2021

Done!
There are several issues I just opened which I could also do now, depending on whether you think they are a good idea. None of them are breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display single-character percentages on Windows
2 participants