Handle very small pdf's #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sindresorhus would appreciate a review on this when you get a chance. Thanks! |
eric-yuan-vanta
requested review from
sindresorhus
and removed request for
Borewit
|
I rerequested review and github seemed to automatically remove @Borewit. Not sure why! |
Borewit
requested changes
Feb 17, 2023
eric-yuan-vanta
requested review from
Borewit
and removed request for
sindresorhus
Borewit
requested changes
Feb 17, 2023
throw errors lint lint simplify wrap all AI reads in try catch move only ingore to try catch, early return pdf Revert "move only ingore to try catch, early return pdf" This reverts commit 3b90419.
eric-yuan-vanta
force-pushed
the
min-pdf
branch
from
5f1435e to
c10a194
Compare
Borewit
reviewed
Feb 18, 2023
| const buffer = Buffer.alloc(Math.min(maxBufferSize, tokenizer.fileInfo.size)); | ||
| await tokenizer.readBuffer(buffer, {mayBeLess: true}); | ||
| try { | ||
| await tokenizer.ignore(1350); |
There was a problem hiding this comment.
This remains a sensitive point, but is not introduced by this PR.
Maybe we should drop support for specialized PDF formats as text based formats are out of scope.
Borewit
approved these changes
Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle tiny pdf's, and add a test pdf < 1350 bytes (the test pdf is MIT licensed and from https://brendanzagaeski.appspot.com/0004.html)
just fyi generating an empty pdf from google drive results in a pdf of similar size (~700 bytes)
resolves #579