Add support for ACE #592
Merged
Add support for ACE #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Magic number: https://en.wikipedia.org/wiki/List_of_file_signatures
MIME: https://en.wikipedia.org/wiki/List_of_archive_formats
ACE is an archiving format from 1999, it is not widely used, and the software that is capable of creating .ace files (WinAce) is abandonware. However, as per the Wikipedia article: "Since at least 2015, ACE archives have been used to deliver malware to victims by e-mail. This tactic was viable because popular archiving software was able to uncompress ACE archives, but support for the ACE format in security products (...) was generally weak.".
Do note that I edited the magic number offset on that Wikipedia article by experimenting creating ace files on my own, with different contents, the offset was always 7 bytes, but since there is no detailed documentation on the format I cannot be sure that it is the case that it will always be the same. Still I think being able to detect it has value for the aforementioned reason.