Replace node:buffer usage with Uint8Array #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornstar
force-pushed
the
goodbye-nodejs-buffer
branch
from
44442e8
to
49cec46
Compare
Borewit
force-pushed
the
goodbye-nodejs-buffer
branch
from
2fcd9c1
to
4caaee2
Compare
|
I run all music-metadata with success local against 4caaee2, as reported Borewit/music-metadata#2103 (comment), which gives me confidence that the dependent changes in |
|
|
sindresorhus
reviewed
Jul 5, 2024
sindresorhus
approved these changes
Jul 5, 2024
Borewit
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
LGTM, you may conciser to update strtok3 to 7.1.0 to allign dependencies.
Borewit
added
the
API change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's time to say Goodbye, node.js Buffer in this library.
Resolves #578
Dependencies
token-typesto take encoding forStringTypeindexOf&getUintBEtouint8array-extrasThis was an interesting challenge. Please hold while I raise PRs to these two dependencies.Update: PRs raised for both dependencies, I'll come back and update this once they're merged and released.Update: Both dependencies have been updated and released.