Add detecting Web Stream to default (core) entry point #649
+106
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borewit
force-pushed
the
extend-web-stream-with-file-type
branch
3 times, most recently
from
821e8be to
df5b0a0
Compare
Borewit
force-pushed
the
extend-web-stream-with-file-type
branch
from
df5b0a0 to
d7fb48e
Compare
|
This PR undo PR #651, as the constructor is not overridden, there is no need to re-declare it. |
sindresorhus
requested changes
Jul 31, 2024
|
I have committed some changes, so please don't force push and override them. |
|
Ensure the readme and index.d.ts are in sync. |
Borewit
force-pushed
the
extend-web-stream-with-file-type
branch
from
cb9b5a5 to
bff09c8
Compare
Borewit
force-pushed
the
extend-web-stream-with-file-type
branch
from
9825a0b to
257bc99
Compare
sindresorhus
requested changes
Aug 1, 2024
Borewit
force-pushed
the
extend-web-stream-with-file-type
branch
from
53ec046 to
f337a4c
Compare
sindresorhus
reviewed
Aug 2, 2024
sindresorhus
reviewed
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the
fileTypeStream()converting a Node Readable stream, into a detecting stream, add support for web streams.In Node.js you can either use a Node Readable stream, or a Web Stream.
Using the default entry point (core), just supports Web Stream.