-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add findUp.exists()
and findUp.sync.exists()
#41
Add findUp.exists()
and findUp.sync.exists()
#41
Conversation
declare const findUp: {
// ... //
sync.exists(path: string): boolean; //This does not create a nested function (?)
// ... //
} |
@coreyfarrell I believe this is a hard link [Source] Line 40 in da1b331
@sindresorhus create |
@TiagoDanin it might be a hard link in Windows. The symbolic link tests need to be skipped under Windows (see other tests which try to match the links). |
Because of #42, we no longer need the isFile/isDirectory methods. We only need the "exists" methods. |
2834811
to
fceee4b
Compare
ba718d7
to
48a82ec
Compare
@coreyfarrell Looks good to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sindresorhus the code looks good to me. I made a couple comments about the docs, up to you if you want those minor tweaks made.
findUp.exists()
and findUp.sync.exists()
Closes #37