Add findUpMultiple() method
#56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would reduce the duplication. For posterity, here's a diff:
|
|
If |
sindresorhus
requested changes
Oct 4, 2021
index.d.ts
Outdated
|
|
||
| console.log(await findUpMultiple(async directory => { | ||
| const hasUnicorns = await pathExists(path.join(directory, 'unicorn.png')); | ||
| return hasUnicorns && directory; |
Thanks. Fixed: |
Done in: I introduced What do you think? |
sindresorhus
requested changes
Oct 6, 2021
index.d.ts
Outdated
| Find files or directories by walking up parent directories. | ||
|
|
||
| @param name - The name of the file or directory to find. Can be multiple. | ||
| @returns All paths found (by respecting the order of `name`s) or `undefined` if none could be found. |
index.js
Outdated
|
|
||
| export async function findUp(name, options = {}) { | ||
| const matches = await findUpMultiple(name, {...options, limit: 1}); | ||
|
|
sindresorhus
reviewed
Oct 7, 2021
readme.md
Outdated
| ### findUpMultiple(name, options?) | ||
| ### findUpMultiple(matcher, options?) | ||
|
|
||
| Returns a `Promise` for either the array of paths or an empty array if it couldn't be found. |
There was a problem hiding this comment.
I don't think "it" is correct here. This method is for finding multiple things. The index.d.ts description is correct though.
There was a problem hiding this comment.
Thanks! Updated in:
6ee09a3
sindresorhus
reviewed
Oct 7, 2021
readme.md
Outdated
| ### findUpMultiple(name, options?) | ||
| ### findUpMultiple(matcher, options?) | ||
|
|
||
| Returns a `Promise` for either the array of paths or an empty array if it couldn't be found. |
There was a problem hiding this comment.
Suggested change
| Returns a `Promise` for either the array of paths or an empty array if it couldn't be found. | |
| Returns a `Promise` for either an array of paths or an empty array if it couldn't be found. |
|
Thanks ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27.
I'm a bit concerned about the amount of duplication in code: looks like
findUpcould be a decorated version offindUpMultiple. On the other hand, duplication is cheaper than wrong abstraction. What do you think?P. S. PR looks huge. Let me know if that's a problem, I'll split it in multiple smaller PRs.
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
findUpMultiple()method