New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop re-exporting path-exists #69

Open

benmccann wants to merge 1 commit into sindresorhus:main from benmccann:rm-path-exists

benmccann commented Jul 2, 2024

This would be a breaking change, but is a suggestion I wanted to make for the next major version. Most consumers of this package won't need to call pathExists. E.g. I saw eslint using this package without checking if paths exist: https://github.com/eslint/eslint/blob/9e6d6405c3ee774c2e716a3453ede9696ced1be7/lib/eslint/eslint.js#L15

Additionally, pathExistsSync is available in Node.js as fs.existsSync and fs.stat/fs.access can often be used in place of pathExists


          Stop re-exporting path-exists

f118346

benmccann force-pushed the rm-path-exists branch from 73e205d to f118346 Compare

July 2, 2024 17:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet