Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Don't allow lockfiles #71

Merged
merged 1 commit into from
Jun 29, 2017
Merged

Don't allow lockfiles #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ module.exports = class extends Generator {
mv('gitattributes', '.gitattributes');
mv('gitignore', '.gitignore');
mv('travis.yml', '.travis.yml');
mv('npmrc', '.npmrc');
mv('_package.json', 'package.json');
});
}
Expand Down
1 change: 1 addition & 0 deletions app/templates/gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
node_modules<% if (nyc) { %>
.nyc_output
coverage<% } %>
yarn.lock
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I care enough to add this to be honest. I'll think about it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if I don't like yarn, I think it should be added so yarn users can contribute without switching tools or manually discard there lockfile

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like neither yarn nor npm. It's just that I don't use yarn as it's been too unstable for me. I guess you're right though, should be included to prevent it accidentally included in PRs.

1 change: 1 addition & 0 deletions app/templates/npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
package-lock=false
3 changes: 2 additions & 1 deletion test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ test.serial('generates expected files', async () => {
'license',
'package.json',
'readme.md',
'test.js'
'test.js',
'.npmrc'
]);

assert.noFile('cli.js');
Expand Down