Auto create PR when data updated #7
Conversation
| @@ -104,8 +104,8 @@ const text = await response.text(); | |||
| const parsed = parse(text); | |||
| const functions = generateFunctions(parsed); | |||
|
|
|||
| fs.writeFileSync( | |||
There was a problem hiding this comment.
Synchronous writing is significantly faster than async when you don't need concurrency, so the only way this change is beneficial is if you do the two file writings with Promise.all.
|
Any idea why it suddenly started failing? https://github.com/sindresorhus/get-east-asian-width/actions/runs/10976824563/job/30478041494#step:6:92 |
|
IDK, but a manual run on my fork works https://github.com/fisker/get-east-asian-width/actions/runs/10994838817 Try to upgrade the action? https://github.com/peter-evans/create-pull-request/blob/main/docs/updating.md#updating-from-v6-to-v7 |
|
It still fails, I'll figure out if it needs permissions. |
|
@sindresorhus Looks like the job still failed last week, can you check if this setting is correct? peter-evans/create-pull-request#2767 (comment) |
|
It was not enabled. Enabled now. |
Tested on my fork.
CI job
PR