Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#121 added the
on(stream, 'data')
'shighWatermark
option. However, I realized this does not make sense in this specific case.That option is measured in number of
data
events, not in bytes. My PR assumed it was measured in bytes. Since we cannot know the average number of bytes perdata
event (i.e. perreadable.push()
), we cannot know the optimal value for this option.Also, the point of
get-stream
is already to buffer all stream data. So this is not a big problem ifon(stream, 'data')
buffers it too: if some data is buffered byon()
, it is not consumed yet. Once consumed, it will be buffered byget-stream
instead. So using this option does not actually reduce memory consumption.Finally,
get-stream
's processing of each chunk is synchronous and fairly fast, so having a backlog ofdata
events is unlikely.