Don't override authorization header if it already exists
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only use `options.token` to set `options.headers.authorization` if that header is current unset. This covers the case where: 1. User has a `GITHUB_TOKEN` defined in env 2. User/app has explicitly set an authorization header and is definitely not expecting it to get ignored/overwritten
|
Can you document this behavior in the readme? |
sindresorhus
changed the title
authorization header if it already exists
|
@sindresorhus done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only use
options.tokento setoptions.headers.authorizationif that header is current unset.This covers the case where:
GITHUB_TOKENdefined in envThis is particularly important also for GitHub "Apps" which need to authentication themselves via
Bearernottoken, so it's impossible to pass that inoptions.tokeneither.