Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jasmine globals (3.x) #151

Closed
elliot-nelson opened this issue Jun 18, 2019 · 0 comments · Fixed by #152
Closed

Update jasmine globals (3.x) #151

elliot-nelson opened this issue Jun 18, 2019 · 0 comments · Fixed by #152

Comments

@elliot-nelson
Copy link

elliot-nelson commented Jun 18, 2019

I'd like to see the new globals from jasmine 3.4 added to the globals list, so that specifying env: jasmine in eslint includes globals like spyOnAllFunctions without having to add it manually to the .eslintrc.

I see the discussion in #82, and I'm not sure what the current status is -- is globals accepting PRs for adding globals to existing definitions, or is it already moving to separate plugins?

There exists a plugin today, eslint-plugin-jasmine, that is only a bundle of rules today. I'd be willing to make pull requests there to propose exporting a custom env, but if it exports the env "jasmine", will that be useable in .eslintrc? (I assume, perhaps, it would be env: "jasmine/jasmine" instead of just "jasmine").

Looking for input on where I should be making these changes...

UziTech added a commit to UziTech/globals that referenced this issue Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant